Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[linux] add ThreadStackManager for Linux Device layer #1320Thread linux #1438

Merged
merged 9 commits into from
Jul 8, 2020

Conversation

gjc13
Copy link
Contributor

@gjc13 gjc13 commented Jul 3, 2020

Problem

This PR adds ThreadStack manager in the linux device layer.
It relies on otbr-agent as the Thread daemon.

Summary of Changes

-Add ot-br-posix submodule
-Implementation of ThreadStackManager
-Functional tests for ThreadStackManager

fixes #740

@gjc13 gjc13 changed the title Thread linux [linux] add ThreadStackManager for Linux Device layer #1320Thread linux Jul 3, 2020
@gjc13 gjc13 force-pushed the thread-linux branch 3 times, most recently from a378289 to 3b0e01e Compare July 3, 2020 10:58
Copy link
Contributor

@turon turon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good. Posted comments seeking improvements to hide Linux-specific details inside Device Layer rather than require app or test to handle those with ifdef.

src/platform/tests/TestThreadStackMgr.cpp Outdated Show resolved Hide resolved
src/platform/tests/TestThreadStackMgr.cpp Outdated Show resolved Hide resolved
@gjc13 gjc13 force-pushed the thread-linux branch 2 times, most recently from 7e89da7 to efaebe1 Compare July 6, 2020 08:51
@gjc13 gjc13 requested a review from turon July 6, 2020 08:57
@gjc13
Copy link
Contributor Author

gjc13 commented Jul 6, 2020

Hi there, this PR requires the dbus package to be installed into our build environment in github actions. Currently I've manually installed it in the CI config and updated the Dockerfile as well. I believe we should upload a new version of base build image to dockerhub. Is there a guide on how to achieve this?

.github/workflows/build.yaml Outdated Show resolved Hide resolved
@gjc13 gjc13 requested a review from woody-apple July 7, 2020 15:39
@CLAassistant
Copy link

CLAassistant commented Jul 7, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@turon turon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@BroderickCarlin BroderickCarlin merged commit 10be6f0 into project-chip:master Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[linux] Linux ConnectivityMgr should support Thread
6 participants