-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[linux] add ThreadStackManager for Linux Device layer #1320Thread linux #1438
Conversation
a378289
to
3b0e01e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good. Posted comments seeking improvements to hide Linux-specific details inside Device Layer rather than require app or test to handle those with ifdef
.
7e89da7
to
efaebe1
Compare
Hi there, this PR requires the dbus package to be installed into our build environment in github actions. Currently I've manually installed it in the CI config and updated the Dockerfile as well. I believe we should upload a new version of base build image to dockerhub. Is there a guide on how to achieve this? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Problem
This PR adds ThreadStack manager in the linux device layer.
It relies on otbr-agent as the Thread daemon.
Summary of Changes
-Add ot-br-posix submodule
-Implementation of ThreadStackManager
-Functional tests for ThreadStackManager
fixes #740